Fix source name persistence (#391)#501
Draft
RhysSullivan wants to merge 1 commit intomainfrom
Draft
Conversation
- refreshSource: prefer existing saved name over MCP manifest name so user renames survive a refresh - updateSource: re-register source via ctx.core.sources.update inside the same transaction as the storage write so the sidebar/home page reflect renames immediately instead of after a full reload - cloud sidebar: title attribute on source name for hover tooltip Partial fix for #391 (secret label editing still pending).
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 14c48cf | Commit Preview URL Branch Preview URL |
May 04 2026, 08:10 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 14c48cf | May 04 2026, 08:10 AM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/storage-core
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-google-discovery
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partial fix for #391 — three of the four reported problems:
refreshSourcewas preferring the MCP server's manifest name over the user's saved name (manifest.server?.name ?? existing?.name ?? namespace). Flipped toexisting?.name ?? manifest.server?.name ?? namespaceso user renames survive a refresh.updateSourcewas writing to plugin storage but never updating the executor's in-memory source row. Added actx.core.sources.update({ id, scope, name, url })call inside the samectx.transactionas the storage write so both stay in sync atomically.title={s.name}so the full name shows in a hover tooltip. (Resizable sidebar intentionally out of scope here.)Still open from #391 (separate PR): secret label editing — there's no
updatehandler in the secrets API today.Test plan
bun run --cwd packages/plugins/mcp typecheckbun run --cwd apps/cloud typecheckbun run --cwd packages/plugins/mcp test— 46/46 pass